This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 360
[FEATURE] Support overlapping pipeline communication and computation #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZYHowell
force-pushed
the
overlapping
branch
from
November 13, 2022 03:34
f1a4cfd
to
8ce29e4
Compare
ZYHowell
changed the title
[FEATURE] Support overlapping pipeline communication and computation
[WIP][FEATURE] Support overlapping pipeline communication and computation
Nov 13, 2022
ZYHowell
force-pushed
the
overlapping
branch
from
November 13, 2022 22:19
e488d07
to
7619897
Compare
ZYHowell
force-pushed
the
overlapping
branch
from
November 23, 2022 06:19
f1bd67b
to
72b0fd0
Compare
ZYHowell
changed the title
[WIP][FEATURE] Support overlapping pipeline communication and computation
[FEATURE] Support overlapping pipeline communication and computation
Nov 23, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
GpuEvent
s during the pipeline execution, then use the event level synchronization. The overlapping is only supported with XLA implementation, because with CuPy implementation, there is a CPU-GPU synchronization when transforming from Xla buffer to Cupy buffers.a
andb
are the output of layeri
andj
, respectively.c = a + b
is used in layerk
.TODO of next PR:
The current blocker is that some code seems to synchronize cpu thread to gpus. We need to find out where they are.
This is because in the slow path, there is a dynamic slice enqueued to the end of computational stream, making communication have to wait until all computations are done, which has no overlap then.